Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opa Authorization Handler for AspNetCore #5146

Merged
merged 19 commits into from
Oct 30, 2022
Merged

Opa Authorization Handler for AspNetCore #5146

merged 19 commits into from
Oct 30, 2022

Conversation

queil
Copy link
Contributor

@queil queil commented Jun 13, 2022 •
edited
Loading

Implement authorization handler delegating authz to an OPA (Open Policy Agent) REST API endpoint. The handler should send a POST request to an OPA Data API endpoint.

queil added 4 commits June 13, 2022 14:10
@queil
Squashed commit of the following:
ceb3bb3 
commit 857d7e4
Author: queil <queil@users.noreply.github.com>
Date:   Mon Jun 13 13:57:49 2022 +0100

    Fix tests

commit 541972a
Merge: aca6c5d 7f79c08
Author: queil <queil@users.noreply.github.com>
Date:   Mon Jun 13 13:50:39 2022 +0100

    Merge branch 'opa-auth' of github.com:AccountTechnologies/hotchocolate into opa-auth

commit aca6c5d
Author: queil <queil@users.noreply.github.com>
Date:   Wed Jun 8 16:18:16 2022 +0100

    Formatting + missing ConfigureAwait

commit bdf12c3
Author: queil <queil@users.noreply.github.com>
Date:   Tue Apr 5 15:04:16 2022 +0100

    Tests tweaks

commit 8de3562
Author: queil <queil@users.noreply.github.com>
Date:   Tue Mar 29 23:10:53 2022 +0100

    Convert timeout to ms + clean up

commit 06d29b3
Author: queil <queil@users.noreply.github.com>
Date:   Tue Mar 29 18:21:23 2022 +0100

    Further refinement

commit 764fbd1
Author: queil <queil@users.noreply.github.com>
Date:   Tue Mar 29 10:01:31 2022 +0100

    Introduce policy result handlers

commit 08ecbb9
Author: queil <queil@users.noreply.github.com>
Date:   Wed Feb 2 20:10:52 2022 +0000

    Configure await false

commit 242059a
Author: queil <queil@users.noreply.github.com>
Date:   Wed Feb 2 19:54:46 2022 +0000

    Deleted redundant snapshots

commit e97e2b7
Author: queil <queil@users.noreply.github.com>
Date:   Wed Feb 2 19:43:02 2022 +0000

    Added more tests

commit 1ca4126
Author: queil <queil@users.noreply.github.com>
Date:   Wed Feb 2 17:31:25 2022 +0000

    fix: OPA result field serialization
    fix: mapping no default policy and policy not found responses

commit 46363c2
Author: queil <queil@users.noreply.github.com>
Date:   Mon Jan 31 16:00:17 2022 +0000

    fix: property fails deserializing in netcore3.1
    chore: upgrade Opa

commit 97777dd
Author: queil <queil@users.noreply.github.com>
Date:   Mon Jan 10 18:34:53 2022 +0000

    Make the first test pass

commit c838c37
Author: queil <queil@users.noreply.github.com>
Date:   Wed Jan 5 01:42:59 2022 +0000

    Iteration 3

commit b79d5d4
Author: queil <queil@users.noreply.github.com>
Date:   Tue Jan 4 23:21:55 2022 +0000

    Iteration 2

commit a40dd0e
Author: queil <queil@users.noreply.github.com>
Date:   Tue Jan 4 15:53:20 2022 +0000

    Remove auto-created project

commit ee47a03
Author: queil <queil@users.noreply.github.com>
Date:   Tue Jan 4 15:50:00 2022 +0000

    Some initial works

commit 7f79c08
Author: queil <queil@users.noreply.github.com>
Date:   Wed Jun 8 16:18:16 2022 +0100

    Formatting + missing ConfigureAwait

commit 00c810e
Author: queil <queil@users.noreply.github.com>
Date:   Tue Apr 5 15:04:16 2022 +0100

    Tests tweaks

commit f3ea08b
Author: queil <queil@users.noreply.github.com>
Date:   Tue Mar 29 23:10:53 2022 +0100

    Convert timeout to ms + clean up

commit 278f377
Author: queil <queil@users.noreply.github.com>
Date:   Tue Mar 29 18:21:23 2022 +0100

    Further refinement

commit acfbcd9
Author: queil <queil@users.noreply.github.com>
Date:   Tue Mar 29 10:01:31 2022 +0100

    Introduce policy result handlers

commit ec3c807
Author: queil <queil@users.noreply.github.com>
Date:   Wed Feb 2 20:10:52 2022 +0000

    Configure await false

commit c9cda84
Author: queil <queil@users.noreply.github.com>
Date:   Wed Feb 2 19:54:46 2022 +0000

    Deleted redundant snapshots

commit d79f385
Author: queil <queil@users.noreply.github.com>
Date:   Wed Feb 2 19:43:02 2022 +0000

    Added more tests

commit 279e2ee
Author: queil <queil@users.noreply.github.com>
Date:   Wed Feb 2 17:31:25 2022 +0000

    fix: OPA result field serialization
    fix: mapping no default policy and policy not found responses

commit 8117bdb
Author: queil <queil@users.noreply.github.com>
Date:   Mon Jan 31 16:00:17 2022 +0000

    fix: property fails deserializing in netcore3.1
    chore: upgrade Opa

commit 59d9294
Merge: e43a74d ce10dd3
Author: queil <4584075+queil@users.noreply.github.com>
Date:   Mon Jan 31 15:32:48 2022 +0000

    Merge branch 'ChilliCream:main' into opa-auth

commit e43a74d
Author: queil <queil@users.noreply.github.com>
Date:   Mon Jan 10 18:34:53 2022 +0000

    Make the first test pass

commit c05164f
Author: queil <queil@users.noreply.github.com>
Date:   Wed Jan 5 01:42:59 2022 +0000

    Iteration 3

commit 64074fc
Author: queil <queil@users.noreply.github.com>
Date:   Tue Jan 4 23:21:55 2022 +0000

    Iteration 2

commit 645a32f
Author: queil <queil@users.noreply.github.com>
Date:   Tue Jan 4 15:53:20 2022 +0000

    Remove auto-created project

commit 32e375e
Author: queil <queil@users.noreply.github.com>
Date:   Tue Jan 4 15:50:00 2022 +0000

    Some initial works
@queil
Fix sln + encoding
aa1ec3c
@queil
Fix
c9229d8
@queil
Fix solution - again
3a579d0
@queil queil mentioned this pull request Jun 13, 2022
Closed
queil and others added 5 commits June 13, 2022 16:19
@queil
Implement 'policy not found' behaviour
2d29d1e 
Update OPA package in tests
Remove 'default policy not found' tests (OPA does not support this in the /v1/data API)
@queil
More fixes + tests
42ecf4a
@queil
EOL
c3787dc
@queil
EOL
380d384
@queil
Merge branch 'ChilliCream:main' into opa-auth-2
3a61f50
@queil
Copy link
Contributor Author

queil commented Jun 14, 2022

@PascalSenn I think I am ready for a review.

@michaelstaib
Copy link
Member

Hey sorry for the wait ... we will do the review this week.

@michaelstaib
Copy link
Member

I will do a bit of reformatting so that it fits with the code-style. Looks great so far.

@michaelstaib michaelstaib added this to the HC-13.0.0 milestone Jul 12, 2022
@CLAassistant
Copy link

CLAassistant commented Aug 17, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ChilliCream ChilliCream deleted a comment from cla-bot bot Sep 15, 2022
@ChilliCream ChilliCream deleted a comment from cla-bot bot Sep 15, 2022
@ChilliCream ChilliCream deleted a comment from cla-bot bot Sep 15, 2022
@michaelstaib michaelstaib merged commit 6565f19 into ChilliCream:main Oct 30, 2022
@michaelstaib
Copy link
Member

I have merged it now into the V13 branch aka main. I will go over the interfaces before we do a final release. I think a couple could be internal .... I will ship the new package with preview 74

@michaelstaib
Copy link
Member

Hey @queil in the test is a reference to a local server and all tests seem always to fail. Can you containerize this server? So we can package it with squadron for the tests?

@queil
Copy link
Contributor Author

queil commented Nov 5, 2022 •
edited
Loading

Sure, it should be trivial. I'll take a look shortly.

@michaelstaib
Copy link
Member

Awesome thank you

@queil
Copy link
Contributor Author

queil commented Nov 8, 2022

OPA Server is already available as a Docker image. Does this work for you guys? https://hub.docker.com/r/openpolicyagent/opa/ Also, I'd probably should remove the embedded server from the tests though.

@michaelstaib
Copy link
Member

Yes, lets package that up in squadron and then we can use the docker image in the tests.

@michaelstaib
Copy link
Member

I will create an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees

@queil queil

Labels
🌶️ hot chocolate
Projects
None yet
Milestone
HC-13.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@queil @michaelstaib @CLAassistant